Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 64bit integer properly #104

Open
bylee20 opened this issue Dec 20, 2019 · 1 comment
Open

Support 64bit integer properly #104

bylee20 opened this issue Dec 20, 2019 · 1 comment

Comments

@bylee20
Copy link

bylee20 commented Dec 20, 2019

The example code utilizes 64bit integer, but it does not support 64bit integer actually.

For instance, slope comparison is done with multiplication of two coordinate delta and therefore, one if each coordinate value exceeds 32bit range, it causes overflow.
Original Clipper utilizes 128bit integer operation to compare slope.

@flippmoke
Copy link
Member

Yes, there are several parts of the code that would need to be updated to support this properly and you are absolutely correct. I do not see myself having time to add support for this, but definitely willing to support reviewing a PR for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants