You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ideally, Mochify would use Browserify 17 (instead of 16 at the time of writing) to keep in sync with maintained versions of the underlying tools.
Picking up the comment here: #223 (comment) I looked into why such an update from 16 to 17 is breaking Mochify and found out the following (this issue is mostly about collecting what I found out for whenever this updates becomes required for some reason):
There is yet another new deprecation warning about the usage of SharedArrayBuffer that litters stderr, but that can be swallowed just as Mochify already does with other deprecation messages. (SharedArrayBuffer changes in Chrome 91+ browserify/node-util#58)
After muting these warnings, the tests for --no-detect-globals fail because of the following:
Browserify 17 updates util to 0.12 Upgrade util to v0.12.0. browserify/browserify#1844, containing this commit browserify/node-util@6b82825 which is reading process.env.NODE_DEBUG without checking whether process is even defined. This means that when passing the option not to shim globals to browserify, any code that requires util (Mocha for example) will fail with an Uncaught ReferenceError: process is not defined
I'm not entirely sure if this is something that could be or should be worked around in Mochify or if this is something that is to be considered an upstream bug in either node-util or browserify. Mochify could of course also drop the --no-detect-globals flag again but this would mean #208 comes back to life.
The text was updated successfully, but these errors were encountered:
Ideally, Mochify would use Browserify 17 (instead of 16 at the time of writing) to keep in sync with maintained versions of the underlying tools.
Picking up the comment here: #223 (comment) I looked into why such an update from 16 to 17 is breaking Mochify and found out the following (this issue is mostly about collecting what I found out for whenever this updates becomes required for some reason):
SharedArrayBuffer
that littersstderr
, but that can be swallowed just as Mochify already does with other deprecation messages. (SharedArrayBuffer
changes in Chrome 91+ browserify/node-util#58)--no-detect-globals
fail because of the following:Browserify 17 updates
util
to 0.12 Upgrade util to v0.12.0. browserify/browserify#1844, containing this commit browserify/node-util@6b82825 which is readingprocess.env.NODE_DEBUG
without checking whetherprocess
is even defined. This means that when passing the option not to shim globals to browserify, any code that requiresutil
(Mocha for example) will fail with anUncaught ReferenceError: process is not defined
I'm not entirely sure if this is something that could be or should be worked around in Mochify or if this is something that is to be considered an upstream bug in either
node-util
orbrowserify
. Mochify could of course also drop the--no-detect-globals
flag again but this would mean #208 comes back to life.The text was updated successfully, but these errors were encountered: