Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-on-modifier deprecation warnings #363

Open
sepuckett86 opened this issue Jul 21, 2023 · 0 comments
Open

ember-on-modifier deprecation warnings #363

sepuckett86 opened this issue Jul 21, 2023 · 0 comments

Comments

@sepuckett86
Copy link

I'm seeing these deprecation warnings while in an app on Ember 3.28 using ember-cli-notifications:


import { deprecate } from '@ember/application/deprecations';has been deprecated, please update toimport { deprecate } from '@ember/debug';` [deprecation id: old-deprecate-method-paths]

deprecate.js:117 DEPRECATION: When calling deprecate you must provide for in options. Missing options.for in "ember-on-modifier.prevent-default" deprecation [deprecation id: ember-source.deprecation-without-for]

deprecate.js:117 DEPRECATION: When calling deprecate you must provide since in options. Missing options.since in "ember-on-modifier.prevent-default" deprecation [deprecation id: ember-source.deprecation-without-since]

DEPRECATION: (prevent-default) has been moved to ember-event-helpers. [deprecation id: ember-on-modifier.prevent-default] See https://github.com/buschtoens/ember-event-helpers for more details.


npm ls ember-on-modifier shows these warnings are linked to ember-cli-notifications:

└─┬ [email protected]
└── [email protected]

If I remove ember-cli-notifications from the app, these warnings go away. If I update Ember to 4.0, these are breaking failures.

Thanks for your time, any fixes would be much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant