-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] click event on links in notification message #270
base: main
Are you sure you want to change the base?
[BUGFIX] click event on links in notification message #270
Conversation
|
||
|
||
# IDE / Code Editor configs | ||
/.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this added on purpose? Usually environment specific things like developers' IDEs make more sense in a global .gitignore
Closes #274 |
@Shajansheriff I think a better solution to this would be to move the close button outside of the div that has the onClick handler and absolutely position it to the top right inside the outer container. That way we don't need to stop propagation. Of course the outer container should have |
@LuisAverhoff no that workaround is not applicable. This fix and the issue is about having links in notification content that become unclickable. |
The fix proposed by @Shajansheriff involves calling |
Fix 269