Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causes issue with angular universal #1294

Open
CharlieGreenman opened this issue Dec 31, 2022 · 1 comment
Open

Causes issue with angular universal #1294

CharlieGreenman opened this issue Dec 31, 2022 · 1 comment

Comments

@CharlieGreenman
Copy link

CharlieGreenman commented Dec 31, 2022

Very difficult to track and will cross reference with angular universal repo. No need for anything to change from the logic side of things. It's just that it bleeds through to the terminal and I found it incredibly confusing and spent much time tracking down this error.

setupRefreshTimer() {
    if (typeof window === 'undefined') {
--> this right here will show in terminal and very hard to track: this.debug('timer not supported on this plattform');
      return;
    }
    if (this.hasValidIdToken() || this.hasValidAccessToken()) {
      this.clearAccessTokenTimer();
      this.clearIdTokenTimer();
      this.setupExpirationTimers();
    }
    if (this.tokenReceivedSubscription) this.tokenReceivedSubscription.unsubscribe();
    this.tokenReceivedSubscription = this.events.pipe((0,rxjs_operators__WEBPACK_IMPORTED_MODULE_3__.filter)(e => e.type === 'token_received')).subscribe(_ => {
      this.clearAccessTokenTimer();
      this.clearIdTokenTimer();
      this.setupExpirationTimers();
    });
  }
@CharlieGreenman
Copy link
Author

Made a pull request here to solve this error: #1295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant