Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pydantic pattern for non-hashable default values (i.e. lists) #2543

Open
mr-tz opened this issue Dec 17, 2024 · 0 comments
Open

use pydantic pattern for non-hashable default values (i.e. lists) #2543

mr-tz opened this issue Dec 17, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mr-tz
Copy link
Collaborator

mr-tz commented Dec 17, 2024

update our remaining code to use this pattern.

          My understanding is that pydantic handles this correctly (i.e. deep copy) for non-hashable default values (i.e. lists). source: https://docs.pydantic.dev/latest/concepts/models/#fields-with-non-hashable-default-values

Originally posted by @mike-hunhoff in #2537 (comment)
@mr-tz mr-tz added the good first issue Good for newcomers label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mr-tz