Skip to content

Latest commit

 

History

History
28 lines (19 loc) · 1.66 KB

pull_request_template.md

File metadata and controls

28 lines (19 loc) · 1.66 KB

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to HACL*? Put an x in the boxes that apply

  • Proof maintenance (non-breaking change which fixes a proof regression)
  • Bugfix (non-breaking change which fixes an issue)
  • New algorithm or feature (non-breaking change which adds functionality)
  • Improved performance (fix or feature that would improve performance of some algorithm on some platform)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md doc
  • I have read and agree to submit my changes under the LICENSE
  • I have added necessary documentation (if appropriate)
  • I have edited CHANGES.md (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...