Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken images on web view #17

Open
markCwatson opened this issue Oct 27, 2023 · 8 comments
Open

Broken images on web view #17

markCwatson opened this issue Oct 27, 2023 · 8 comments

Comments

@markCwatson
Copy link

Many pages on the web view have broken images. For example, here https://maksimdrachov.github.io/zephyr-rtos-tutorial/docs/3-threads/introduction.html

image
@Bardoctorus
Copy link

While it hasn't been fixed, I think the reason for this can be found in Issue 11.

@markCwatson
Copy link
Author

Ah yes, this is a duplicate issue it looks like

@maksimdrachov
Copy link
Owner

Sorry guys, I'm really busy with work; if someone submits a MR I promise to review it tho.

@Bardoctorus
Copy link

Bardoctorus commented Dec 12, 2023 via email

@maarten1C96
Copy link
Contributor

maarten1C96 commented Apr 3, 2024

I think the image paths only need to two extra parent directory references. For example instead of /images/2-introduction/sample-folder.png, on my computer ../../images/2-introduction/sample-folder.png solves the problem.

(And very fantastic tutorial indeed!!!)

@maarten1C96
Copy link
Contributor

I am willing to take over this issue, is @maksimdrachov still active on his repository? As described in the contribution guide:

"In comments claim that you want to take over the issue. The first person who does this will be assigned to the issue."

@maksimdrachov
Copy link
Owner

Yeah sure, go ahead!

@maarten1C96
Copy link
Contributor

Yes, see pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants