Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Rework the dashboard concept #165

Open
maglub opened this issue Nov 29, 2015 · 2 comments
Open

Feature: Rework the dashboard concept #165

maglub opened this issue Nov 29, 2015 · 2 comments

Comments

@maglub
Copy link
Owner

maglub commented Nov 29, 2015

The way that the table plotconfig is used at the moment, is not very intuitive.

Currently, all entries in the table are shown in index.html, for example when set up like this:

sqlite> select * from plotconfig;
radiators|radiators|12h|12|20|false
default|default|12h|12|20|false
basement|basement|12h|12|10|true
stg3-remote|stg3-remote|12h|12|1|false
stg3|stg3|12h|6|1|true
stg3-panna|stg3-panna|12h|6|1|true
stg3-panna|stg3-panna|24h|12|3|true
stg3-panna|stg3-panna|168h|12|3|true
stg3|stg3|24h|12|2|true
stg3-dt|stg3-dt|24h|12|1.5|true
development|development|12h|12|-1|true
stg3|stg3|168h|12|4|true
sqlite> .schema plotconfig
CREATE TABLE plotconfig (name text, plotgroup text, timespan text, size integer, prio integer, visible boolean);

The next steps:

  • Only show "default" plots in index.html, and display links to the other dashboards.
  • List available dashboards (perhaps as a second level dropdown to "Home)
@maglub
Copy link
Owner Author

maglub commented Nov 29, 2015

I found the "issue", which is that the name and plotgroup fields were mixed up in the php code and templates.

I renamed name to "dashboard" in the php data model (might change it in the table ddl later on as well), and use "plotgroup" to name the graph in index.html. On systems with only "default' dasboard there is no change, but on systems with more than one "dashboard", this is directly visible.

maglub added a commit that referenced this issue Nov 29, 2015
@maglub
Copy link
Owner Author

maglub commented Nov 29, 2015

Fixed already

At the moment, we also have more than one group of graphs, where the concept of what to show when is not very thought through. The idea was to be able to define multiple dashboards, and have multiple groups of plots. At the moment, we display all plots in the table "plotconfig" on the main page index.html, whereas we probably should only display the "default" plots. Other names in the "name" column of the plotconfig table should only be displayed when explicitly requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants