Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Reorganizing templates, using bolt.workspace an… #95

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

notdanilo
Copy link
Contributor

This PR:

  • Reorganizes bolt-cli templates in separated files
  • Starts using bolt.workspace in the generated projects to make it easier to change used bolt version
  • Gets rid of warnings messages about missing features by adding anchor-debug, custom-heap and custom-panic to generated Cargo.toml files
Status Type ⚠️ Core Change Issue
Ready Refactor No No issue

Problem

  • Whole templates are inlined and they make the source code files too big and hard to read
  • Setting up a generated bolt project to use a patched version requires changing all the Cargo subprojects
  • Too much warning messages

Solution

  • Create separate template files
  • Use workspace version
  • Clean them :)

@notdanilo
Copy link
Contributor Author

@GabrielePicco I need an approval before merging

@notdanilo notdanilo merged commit c913c28 into main Nov 28, 2024
4 checks passed
@GabrielePicco GabrielePicco deleted the fix/warnings branch November 28, 2024 18:48
@GabrielePicco GabrielePicco restored the fix/warnings branch November 28, 2024 18:49
@GabrielePicco GabrielePicco deleted the fix/warnings branch November 28, 2024 18:49
@notdanilo notdanilo mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants