release: v0.1.11 #112
Merged
release: v0.1.11 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notdanilo
force-pushed
the
release/v0.1.11
branch
from
8855544 to
b518f90
Compare
notdanilo
commented
Dec 4, 2024
Comment on lines
+208
to
+210
| if [ "${DRY_RUN}" != "true" ]; then | ||
| cargo publish --manifest-path=cli/Cargo.toml --token $CRATES_TOKEN | ||
| fi |
There was a problem hiding this comment.
@GabrielePicco
Unlike the other crates, I cannot run cargo publish --manifest-path=cli/Cargo.toml --no-verify because it fails with:
error: failed to prepare local package for uploading
Caused by:
failed to select a version for the requirement `world = "=0.1.11"`
candidate versions found which didn't match: 0.1.10, 0.1.9, 0.1.8, ...
location searched: crates.io index
required by package `bolt-cli v0.1.11 (/root/dev/magicblock-labs/bolt/cli)`
It happens because the crate isn't published yet. This verification is skipped on other crates, like bolt-lang, with -no-verify. But for some reason, it isn't working for bolt-cli.
Would it be probably because it's a binary crate? Idk
There was a problem hiding this comment.
@notdanilo Looks like it's searching on crates.io rather than resolving the world dependency from the local path. We may have to investigate, since with the above change we are not checking anymore that we can correctly publish the cli crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[0.1.11] - 2024-12-04
🐛 Bug Fixes
📚 Documentation
👷 CI/CD
♻️ Refactor