Fix puppet-lint issues

Author: Matthias Baur

manifests/init.pp

@@ -64,7 +64,7 @@
     augeas { 'activemq-maxmemory':
       changes => [ "set wrapper.java.maxmemory ${max_memory}" ],
       incl    => $wrapper,
-      lens    => "Properties.lns",
+      lens    => 'Properties.lns',
       require => Anchor['activemq::package::end'],
       notify  => Service['activemq'],
     }

manifests/package/tarball.pp

@@ -25,57 +25,57 @@
     }
   }
 
-  wget::fetch { "activemq_download":
-    source => "${activemq::apache_mirror}/activemq/apache-activemq/${version}/apache-activemq-${version}-bin.tar.gz",
+  wget::fetch { 'activemq_download':
+    source      => "${activemq::apache_mirror}/activemq/apache-activemq/${version}/apache-activemq-${version}-bin.tar.gz",
     destination => "/usr/local/src/apache-activemq-${version}-bin.tar.gz",
-    require => [User[$user],Group[$group]],
+    require     => [User[$user],Group[$group]],
   } ->
-  exec { "activemq_untar":
+  exec { 'activemq_untar':
     command => "tar xf /usr/local/src/apache-activemq-${version}-bin.tar.gz && chown -R ${user}:${group} ${home}/apache-activemq-${version}",
     cwd     => $home,
     creates => "${home}/apache-activemq-${activemq::version}",
-    path    => ["/bin"],
+    path    => ['/bin'],
     before  => File["${home}/activemq"],
   }
 
   file { "${home}/activemq":
-    owner  => $user,
-    group  => $group,
-    ensure  => "$home/apache-activemq-$version",
-    require => Exec["activemq_untar"],
+    ensure  => "${home}/apache-activemq-${version}",
+    owner   => $user,
+    group   => $group,
+    require => Exec['activemq_untar'],
   } ->
-  file { "/etc/activemq":
+  file { '/etc/activemq':
     ensure  => "${home}/activemq/conf",
     require => File["${home}/activemq"],
   } ->
-  file { "/var/log/activemq":
+  file { '/var/log/activemq':
     ensure  => "${home}/activemq/data",
     require => File["${home}/activemq"],
   } ->
   file { "${home}/activemq/bin/linux":
     ensure  => "${home}/activemq/bin/linux-x86-64",
     require => File["${home}/activemq"],
   } ->
-  file { "/var/run/activemq":
+  file { '/var/run/activemq':
     ensure  => directory,
     owner   => $user,
     group   => $group,
-    mode    => 755,
+    mode    => '0755',
   } ->
-  file { "/etc/init.d/activemq":
+  file { '/etc/init.d/activemq':
     owner   => root,
     group   => root,
-    mode    => 755,
-    content => template("activemq/activemq-init.d.erb"),
+    mode    => '0755',
+    content => template('activemq/activemq-init.d.erb'),
   }
 
-  file { "wrapper.conf":
+  file { 'wrapper.conf':
     path    => $activemq::wrapper,
     owner   => $user,
     group   => $group,
-    mode    => 644,
-    content => template("activemq/wrapper.conf.erb"),
-    require => [File["${home}/activemq"],File["/etc/init.d/activemq"]],
+    mode    => '0644',
+    content => template('activemq/wrapper.conf.erb'),
+    require => [File["${home}/activemq"],File['/etc/init.d/activemq']],
     notify  => Service['activemq'],
   }
 }

manifests/params.pp

@@ -10,13 +10,13 @@
 ) {
 
   # path flag for the activemq init script template
-  case $architecture {
+  case $::architecture {
     'x86_64','amd64': {
       $architecture_flag = '64'
     }
     'i386': {
       $architecture_flag = '32'
     }
-    default: { fail("Unsupported architecture ${architecture}") }
+    default: { fail("Unsupported architecture ${::architecture}") }
   }
 }

manifests/service.pp

@@ -2,8 +2,8 @@
 ) inherits activemq::params {
 
   service { 'activemq':
-    name       => 'activemq',
     ensure     => running,
+    name       => 'activemq',
     hasrestart => true,
     hasstatus  => false,
     enable     => true,