We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since glbOpenAndReadFileWithExtraData uses "rb" mode to open files, on Windows they will retain their CR (\r).
glbind/source/glbind_build.cpp
Line 140 in bb63d02
glbind/source/external/tinyxml2.cpp
Line 2176 in bb63d02
Lines 280 to 292 in bb63d02
So, when the tags in the template file are replaced
Lines 1698 to 1706 in bb63d02
You can check this is the case by compiling and running the build code with MinGW. Checking with git:
glbind $ git ls-files --eol i/lf w/crlf attr/ .gitignore i/lf w/crlf attr/ README.md i/lf w/crlf attr/ build/README.md i/lf w/crlf attr/ examples/01_Triangle/01_Triangle.c i/lf w/crlf attr/ examples/99_ARB_shaders/99_ARB_shaders.c i/lf w/crlf attr/ examples/99_ARB_shaders/resources/FragmentShader.txt i/lf w/crlf attr/ examples/99_ARB_shaders/resources/VertexShader.txt i/lf w/crlf attr/ examples/glbExamplesCommon.c i/lf w/mixed attr/ glbind.h i/lf w/crlf attr/ resources/README.md i/lf w/crlf attr/ source/external/tinyxml2.cpp i/lf w/crlf attr/ source/external/tinyxml2.h i/lf w/crlf attr/ source/glbind_build.cpp i/lf w/crlf attr/ source/glbind_template.h
I made a fix by stripping the CR's #1
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Since glbOpenAndReadFileWithExtraData uses "rb" mode to open files, on Windows they will retain their CR (\r).
glbind/source/glbind_build.cpp
Line 140 in bb63d02
This causes a problem, because despite tinyxml2 also opening the (.xml) file in "rb" mode
glbind/source/external/tinyxml2.cpp
Line 2176 in bb63d02
they strip the CR's before parsing
glbind/source/external/tinyxml2.cpp
Lines 280 to 292 in bb63d02
So, when the tags in the template file are replaced
glbind/source/glbind_build.cpp
Lines 1698 to 1706 in bb63d02
they have only LF line endings.
You can check this is the case by compiling and running the build code with MinGW.
Checking with git:
I made a fix by stripping the CR's #1
The text was updated successfully, but these errors were encountered: