-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicate candump in GO #224
base: main
Are you sure you want to change the base?
Conversation
Checkout the Canlink package in the HIL repo. We have this functionality already. The package does require some work though. @langei would you be able to set up a call with Jinwoo to go over the current status? |
The purpose of this issue was not to just replicate candump. In that case then yes, the HIL code would work. This candump program is supposed to grow into the whole data logging project. We can look at the HIL code for inspiration but it won't replace this code. |
@BlakeFreer and I had a discussion offline about this and the canlink package in the hil repo serves the purpose of the data logging project (this was its intention last year). We need to evaluate what is working, what isn't and what the next steps are for canlink. |
I'm attempting to use canlink for this, and here's a few things I noticed The readme instructs me to increase an instance of Tracer with:
However just initializing with the can interface, directory, and logger attributes gives an error for insufficient arguments. Additionally, the line This is the first thing that would have to be fixed before I can evaluate further, is it possible to go over with or is there any documentation on how canlink works so I can work on getting it running? |
@Jinwoo-H the tracer has been updated, but the documentation was not. The socketcan connection is now passed in as a fourth required parameter to the tracer. This is why you are getting the error Create the connection like below and use it to create your Tracer. conn, err := socketcan.DialContext(context.Background(), "can", "can0")
if err != nil {
...
} |
Replicates functionality of candump within GO. Uses the can package by brutella (https://github.com/brutella/can)
close #214