Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher order discretizations [Enhancement] #24

Open
bpfel opened this issue Aug 10, 2020 · 1 comment
Open

Higher order discretizations [Enhancement] #24

bpfel opened this issue Aug 10, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@bpfel
Copy link

bpfel commented Aug 10, 2020

Dear @m-lundberg,

I am currently working on PID control and wondered whether you considered higher order discretizations like a backward Euler or the Tustin/Trapezoidal method. I am not entirely certain how much we might benefit from such an adaptation, but I think your framework is really powerful and neat. Embedding a higher order controller in it would allow an easy comparison of different discretizations.

For an overview of the above mentioned methods consider this webpage.

Please respond if you are interested / still accepting contributions.

Best,

Gianni

@bpfel bpfel changed the title Higher order discretizations Higher order discretizations [Enhancement] Aug 10, 2020
@m-lundberg
Copy link
Owner

Hello,

Thanks for your input. I am accepting contributions, but since I don't have a lot of time to put on this project I can be pretty slow to respond (as you may have noticed).

I'm not familiar with the techniques you mention but it would certainly be interesting to learn more about them. My only concern would be that adding them to this library might increase the complexity too much, it was always intended as a simple PID implementation (hence the name). I am definitely open to looking into it more though. If it could be implemented in a way that doesn't make the library harder to use or understand it could be an interesting addition.

@m-lundberg m-lundberg added the enhancement New feature or request label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants