Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerhub builds are always "dirty" #96

Open
stephen-soltesz opened this issue Jul 1, 2020 · 0 comments
Open

dockerhub builds are always "dirty" #96

stephen-soltesz opened this issue Jul 1, 2020 · 0 comments

Comments

@stephen-soltesz
Copy link
Contributor

The change from #90 works locally but appears to unconditionally fail during dockerhub builds. We first noticed this on 2020-06-30, though it's been this way on the platform since 2020-03-24.

Step 5/10 : RUN go get -v -ldflags "-X github.com/m-lab/go/prometheusx.GitShortCommit=$(git log -1 --format=%h)$(git diff --quiet || echo dirty)" github.com/m-lab/pusher
---> Running in 7ea47bd89a9b
�[91m fatal: not a git repository: /src/bpge2z8lqrw3la8xeglknwz/.git/modules/travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant