Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics are poorly named #266

Open
pboothe opened this issue Jan 3, 2020 · 1 comment
Open

Metrics are poorly named #266

pboothe opened this issue Jan 3, 2020 · 1 comment
Labels
backlog P3

Comments

@pboothe
Copy link
Contributor

pboothe commented Jan 3, 2020 •
edited
Loading

We named the metrics for this server before we had knowledge about what Prometheus names should look like. Unsurprisingly, we got it wrong a bunch.

Metrics are recommended to all be lowercase, and prometheusx.promlint in http://github.com/m-lab/go/ will actually provide compile-time checks of name quality.

The metric that caused this issue to be created was: annotator_Request_Response_Time_Summary, about which the linter says:

Bad metric annotator_Request_Response_Time_Summary: metric name should not include type 'summary'
@autolabel autolabel bot added the review/triage Team should review and assign priority label Jan 3, 2020
@pboothe
Copy link
Contributor Author

pboothe commented Jan 8, 2020

Remediated the build breakage in #267 .

Still need to fix the underlying problem.

pboothe added a commit that referenced this issue Jan 8, 2020
@pboothe
Make linte errors non-fatal while we remediate #266
62eca82
pboothe added a commit that referenced this issue Jan 8, 2020
@pboothe
Export a function for use in uuid-annotator (#267)
2fd1fd0 
* Export a function for use in uuid-annotator
* Make linter errors non-fatal while we remediate #266
@pboothe pboothe added P3 backlog and removed review/triage Team should review and assign priority labels Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pboothe