Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up "directory" package #196

Open
gfr10598 opened this issue Feb 4, 2019 · 0 comments
Open

Clean up "directory" package #196

gfr10598 opened this issue Feb 4, 2019 · 0 comments
Assignees

Comments

@gfr10598
Copy link
Contributor

gfr10598 commented Feb 4, 2019

Now that things have been re-organized it looks like "directory" is an increasingly bad name. If you called the directory timeannotator, then you could have the struct TimeAnnotator and then the functions Build and Merge. Build would still take a list of annotators, but Merge could have the type Merge(timeannotators ...TimeAnnotator) TimeAnnotator which makes things all cohere a little better in this module - every exported function then either makes a TimeAnnotator or takes a TimeAnnotator or both.

As a final suggestion, now that Directory only has one element why not make Directory (or TimeAnnotator if you decide to accept my earlier suggestion) a type alias for []annotator ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants