Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support third party development of ASN annotator #182

Open
gfr10598 opened this issue Jan 18, 2019 · 3 comments
Open

Support third party development of ASN annotator #182

gfr10598 opened this issue Jan 18, 2019 · 3 comments

Comments

@gfr10598
Copy link
Contributor

I've created branch "api" (https://github.com/m-lab/annotation-service/tree/api) to tweak the api to make addition of more annotators a bit simpler. The api change allows us to compose annotators, e.g. to combine an IPv6 and IPv4 annotator into a single annotator that handles both, or a Geolocation and ASN annotator into one that handles both.

In addition to an implementation of the annotator function, we also need a loader func:
func (string) (api.Annotator, error)
It takes a string filepath to a google cloud storage object, and loads the corresponding annotator. The loader should use the filepath as a key, but may load more than just one file.

@gfr10598
Copy link
Contributor Author

Apologies for the current state of the repo. We are in the middle of both refactoring to improve the overall code structure and quality, performance improvements, and introducing a cache for multiple datasets. The 'prototype' branch contains a working prototype with many of these changes, which are gradually being merged into master as we add munge the code into a form we are happy with.

@gfr10598 gfr10598 self-assigned this Jan 18, 2019
@pboothe
Copy link
Contributor

pboothe commented Jan 18, 2019

https://www.caida.org/data/routing/routeviews-prefix2as.xml is where you can find the AS data

@gfr10598
Copy link
Contributor Author

FYI, I've also created m-lab/analysis#2
It looks very straightforward to get histogram buckets as per the query I've added there. I think that will, in the end, be much more efficient that the current approach.

Feel free to add questions or clarifications in that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants