Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky metrics test #174

Merged
merged 2 commits into from
Jan 9, 2019
Merged

fix flaky metrics test #174

merged 2 commits into from
Jan 9, 2019

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Jan 9, 2019 •
edited by shelbychen97
Loading

Hopefully fixes #173

This change is Reviewable

@gfr10598 gfr10598 requested a review from pboothe January 9, 2019 16:21
pboothe
pboothe requested changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained

metrics/metrics.go, line 100 at r1 (raw file):

	mux.HandleFunc("/debug/pprof/trace", pprof.Trace)

	// Don't ListenAndServe because we want to be able to GET as soon as this function returns.

Recommend httpx.ListenAndServeAsync in our go library.

@coveralls
Copy link

coveralls commented Jan 9, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1619

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 50.239%
Totals Coverage Status
Change from base Build 1613: 0.1%
Covered Lines: 736
Relevant Lines: 1465
💛 - Coveralls

gfr10598
gfr10598 commented Jan 9, 2019
View reviewed changes
Copy link
Contributor Author

@gfr10598 gfr10598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained

metrics/metrics.go, line 100 at r1 (raw file):

httpx.ListenAndServeAsync
Doesn't do what I need. No port gives :80. :0 fails.

pboothe
pboothe requested changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

metrics/metrics.go, line 100 at r1 (raw file):

Previously, gfr10598 (Gregory Russell) wrote…

httpx.ListenAndServeAsync
Doesn't do what I need. No port gives :80. :0 fails.

Ugh. Add TODO(pboothe), please.

pboothe
pboothe approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

gfr10598
gfr10598 commented Jan 9, 2019
View reviewed changes
Copy link
Contributor Author

@gfr10598 gfr10598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

metrics/metrics.go, line 100 at r1 (raw file):

Previously, pboothe (Peter Boothe) wrote…

Ugh. Add TODO(pboothe), please.

Done.

@gfr10598 gfr10598 merged commit 1169ed2 into master Jan 9, 2019
@gfr10598 gfr10598 deleted the fix-flake branch January 9, 2019 17:21
@gfr10598 gfr10598 self-assigned this Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboothe pboothe pboothe approved these changes

Assignees

@gfr10598 gfr10598

Labels
Sprint 23 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metrics test is flaky
4 participants
@gfr10598 @coveralls @pboothe @kokosta