Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusive zone does not scale on Wayland #2118

Closed
stefonarch opened this issue Sep 13, 2024 · 4 comments
Closed

Exclusive zone does not scale on Wayland #2118

stefonarch opened this issue Sep 13, 2024 · 4 comments
Labels

Comments

@stefonarch
Copy link
Member

stefonarch commented Sep 13, 2024

Screenshot with 3 panels and global scale factor 2:
scaling

Expected Behavior

Maximized windows go not behind panel

Current Behavior

They do with scaling >1

Possible Solution

Scale exclusive zone value accordingly.

Steps to Reproduce (for bugs)
  1. Set a scale value like 1.2 or more
  2. Restart session
  3. Maximize any window
System Information
  • LXQt Version: 2.0, git
@stefonarch stefonarch moved this to Todo/Issues in Wayland Support Sep 13, 2024
@tsujan
Copy link
Member

tsujan commented Sep 13, 2024

Apparently LayerShellQt::Window::setExclusiveZone doesn't follow QT_SCALE_FACTOR.

We can wait for a fix in layer-shell-qt, or we can add a workaround, but if we add a workaround, it'll cause the inverse problem when the original issue is fixed.

@tsujan tsujan changed the title Exclusice zone does not scale Exclusive zone does not scale on Wayland Sep 13, 2024
@tsujan tsujan added the wayland label Sep 13, 2024
@stefonarch
Copy link
Member Author

There are more issues: any applications like lxqt-leave or qterminal -d don't scale at all if launched by shortcut, as do most xwayland windows too (element looks ok, gimp not).
Using wdisplays or kanshi for setting the scale factor has no issues at all.

@tsujan
Copy link
Member

tsujan commented Sep 15, 2024

Using wdisplays or kanshi for setting the scale factor has no issues at all.

That's how it should be done on Wayland. QT_SCALE_FACTOR works fine only on X11. I'm not saying that we should disable it in LXQt Session Settings under Wayland, but adding a tooltip may be a good idea (also because of lxqt/lxqt-session#541 (comment)).

@tsujan
Copy link
Member

tsujan commented Oct 25, 2024

As we know now, LXQt global scaling shouldn't be used under Wayland.

@tsujan tsujan closed this as completed Oct 25, 2024
@github-project-automation github-project-automation bot moved this from Todo/Issues to Done in Wayland Support Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants