-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async support (🚧WIP) #13
Draft
luttje
wants to merge
15
commits into
main
Choose a base branch
from
feature/async-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etter (without print override)
…ter to output, clean up unneeded abstractions for clarity,
…k), except for incrementAssertionCount requiring currentDescribeOrTest to be set, which is tricky if async callbacks can assert at any time
…the same scope and made testing that harder)
…uch information into, hopefull resulting in some cleaner code
(merge toBe fix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #12. For now this still has many problems and missing features.
setExpectedAssertionCount
/incrementAssertionCount
is tricky now that we have async. Somehow we need to scope that.I think the most straight forward fix for tracking assertion counts, is to create a text context and bind and pass that to the test as an 'expect' parameter. That way it would know which assertions to count and increment.
Alternatively, a way that doesn't change the API, could be to keep track of test source code lines and have expect find which test it is called in that way.