Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limited url redirections #353

Open
Nomarian opened this issue Mar 12, 2022 · 2 comments
Open

limited url redirections #353

Nomarian opened this issue Mar 12, 2022 · 2 comments

Comments

@Nomarian
Copy link

proposal to change behavior of http.request{redirect=bool} to integer. behavior should mimic curls --max-time

@alerque
Copy link
Member

alerque commented Mar 19, 2022

Why should the API mimic curl?

This would be a major change to the current API and there would have to be some significant benefit for it to be considered.

@Nomarian
Copy link
Author

Nomarian commented Mar 19, 2022

It seems like a security vulnerability, I have not looked at the code, but an infinite redirect could happen.

Looking at the code, it seems there's a max redirect limit of 5. having control of this variable would be nice. but that eases my worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants