Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit status doesn't return correct result #434

Closed
jwoertink opened this issue Nov 1, 2019 · 0 comments · Fixed by #448
Closed

Exit status doesn't return correct result #434

jwoertink opened this issue Nov 1, 2019 · 0 comments · Fixed by #448
Labels
bug easy/high impact

Comments

@jwoertink
Copy link
Member

These comments explain the issue, but TL;DR: We're using exit_status, but we should use exit_code instead here and here.

luckyframework/lucky#953 (comment)
crystal-lang/crystal#8381 (comment)
jwoertink added a commit that referenced this issue Jan 4, 2020
@jwoertink
Use exit_code over exit_status due to getting the wrong exit value wh…
a33a2ed 
…en an exception happens. exit_status will be deprecated in future versions of crystal. Fixes #434
@jwoertink jwoertink mentioned this issue Jan 4, 2020
Merged
jwoertink added a commit that referenced this issue Jan 4, 2020
@jwoertink
Use exit_code over exit_status due to getting the wrong exit value wh…
b17331a 
…en an exception happens. exit_status will be deprecated in future versions of crystal. Fixes #434 (#448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easy/high impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use exit_code over exit_status luckyframework/lucky_cli
1 participant
@jwoertink