Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple dependency on Joda Time library to allow for other time-based implementations #2

Open
lu4nm3 opened this issue Oct 15, 2018 · 2 comments

Comments

@lu4nm3
Copy link
Owner

lu4nm3 commented Oct 15, 2018

No description provided.

@joshlemer
Copy link

Not sure if you are aware of this, but in Java 8, most of joda time basically got pulled into the JDK, under the java.time package, and what didn't make it into the JDK was repackaged as https://www.threeten.org/threeten-extra/ if I understand correctly. Maybe we can just drop any dependency at all and use java.time, or possibly include threeten-extra.

@lu4nm3
Copy link
Owner Author

lu4nm3 commented Oct 22, 2018

Ah, it's been a while since I used Java 8 heavily so I was not aware of this. I originally wanted to support some sort of type class pattern to support multiple time-based libraries besides Joda. However, from what you're saying, it looks like Java as a whole has converged on Joda's integration in Java 8 so it might make sense to just drop the dependency on Joda completely and rely on the defaults. I think this probably makes the most sense unless one day some new up-and-coming time library shows up which I find unlikely as Joda seems to have everything you could ever want. Thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants