Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print buttons #132

Closed
coudot opened this issue Jul 11, 2024 · 2 comments · Fixed by #183
Closed

Print buttons #132

coudot opened this issue Jul 11, 2024 · 2 comments · Fixed by #183
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@coudot
Copy link
Member

coudot commented Jul 11, 2024

Need to see if we need the print and export buttons.

After migration of DataTables, a new syntax is needed to enable them.

@coudot coudot added this to the 0.6 milestone Jul 11, 2024
@coudot coudot added the enhancement New feature or request label Jul 11, 2024
@abpai94 abpai94 self-assigned this Aug 20, 2024
@coudot
Copy link
Member Author

coudot commented Aug 26, 2024

The current stable version has this buttons:

image

We just need to use the new Datatable options, like https://datatables.net/extensions/buttons/built-in#Print

We may need to review how we call Datatable and follow upgrade notes: https://datatables.net/upgrade/index#Major-releases

For information, we used DataTables 1.10.16 in Service Desk 0.5, and we now use 2.0.8 for Service Desk 0.6.

@coudot coudot assigned coudot and unassigned abpai94 Oct 30, 2024
@coudot coudot linked a pull request Nov 18, 2024 that will close this issue
@coudot coudot changed the title Print and export buttons Print buttons Nov 19, 2024
@coudot
Copy link
Member Author

coudot commented Nov 19, 2024

I restored print buttons in #183

CSV or PDF export is available in datatables, but only relies on displayed data (which can be truncated). We need to think about it if we want to add an export feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants