Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect state calculating? #23

Open
hukaidong opened this issue May 15, 2020 · 0 comments
Open

Incorrect state calculating? #23

hukaidong opened this issue May 15, 2020 · 0 comments

Comments

@hukaidong
Copy link

In function Envirement::GetState, I assumes it gathers relative position and velocity data for human body. Without position of pelvis node (index node 0), in your case, you have 23 node in your model. There should be 22 nodes left recorded index [1, 22].

Here I supposed you excluded pelvis and counting number of node need to processed:

int num_body_nodes = skel->getNumBodyNodes() - 1;

But in real computing step, the code tries to iterate over 21 nodes in middle without very first and last node. (Should the upper bound be nodes.size() instead of nodes.size()-1 ?). And then you appended velocity of pelvis in the end?

for(int i = 1;i<num_body_nodes;i++)

As there's no obvious reason for excluding the last node, and not be mentioned anywhere in your project, is this behavior incorrect or intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant