[topgen] Fail more understandably if we start in an unexpected place #24598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix issue lowRISC#24595. The problem that caused the issue is that we compute paths to the various IP blocks that should be included by following relative paths from the `-t` argument. This doesn't work very well if the top_earlgrey.hjson file moves around! A sensible design would probably point more explicitly at where to find IPs, but this should hopefully be a little easier to debug. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
added
the
Component:Tooling
|
I believe
|
|
Yep, you're right. The issue that prompted the change is triggered by a block that isn't marked if reggen_only and args.hjson_path:
ip_hjson = Path(args.hjson_path) / f"{ip}.hjson"
else:
ip_hjson = hjson_dir.parent / f"ip/{ip}/data/{ip}.hjson"where This change is basically just adding a somewhat helpful error message earlier if the derived directory is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #24595. The problem that caused the issue is that we compute paths to the various IP blocks that should be included by following relative paths from the
-targument. This doesn't work very well if the top_earlgrey.hjson file moves around!A sensible design would probably point more explicitly at where to find IPs, but this should hopefully be a little easier to debug.