Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View should connect to Kafka in Run, not NewView #259

Open
frairon opened this issue Jul 8, 2020 · 1 comment
Open

View should connect to Kafka in Run, not NewView #259

frairon opened this issue Jul 8, 2020 · 1 comment

Comments

@frairon
Copy link
Contributor

frairon commented Jul 8, 2020

Without running Kafka we have different failure behavior between Processors and Views.

Current behavior:

  • NewView returns an error

Intended behavior

  • NewView succeeds
  • view.Run returns either an error or does an internal reconnect, when option WithViewAutoReconnect is passed
@mattburman
Copy link

This would be great!

from #248:

We'll try to release goka to get rid of the huge PR and can fix such things later...

I agree, it can wait :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frairon @mattburman