Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanRomaji breaks valid double N notation #16

Open
risseraka opened this issue Apr 4, 2020 · 1 comment
Open

cleanRomaji breaks valid double N notation #16

risseraka opened this issue Apr 4, 2020 · 1 comment
Labels

Comments

@risseraka
Copy link
Collaborator

Hi there,

This might be an unresolvable issue, but here goes.

Cleaning valid romaji breaks it.

E.g.:

toHiragana(cleanRomaji("DANNA"))
// DAN'A
// だんあ wrong
toHiragana("DANNA")
// DANNA
// だんな correct

I understand that the rationale behind the following code is to correct outdated writing of romaji

// Convert the NN form into the more common N'
str = str.replace(/NN/g, "N'");

but then, how was 旦那 (husband) written? DANNNA?

WDYT?

@lovell
Copy link
Owner

lovell commented Apr 11, 2020

/cc @jeresig who originally contributed this useful feature and may have suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants