Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuaSocket has released version 3.0.0 #1790

Closed
AegisCrusader opened this issue Mar 29, 2022 · 8 comments · Fixed by #1856
Closed

LuaSocket has released version 3.0.0 #1790

AegisCrusader opened this issue Mar 29, 2022 · 8 comments · Fixed by #1856
Assignees
Labels
change Change to existing functionality library dependency Related to a library used by LÖVE
Milestone

Comments

@AegisCrusader
Copy link

https://github.com/lunarmodules/luasocket/releases/tag/v3.0.0

Do you think we should put it in Love 12.x?

@MikuAuahDark
Copy link
Contributor

I'd like to know if there are any breaking changes between 3.0.0-rc1 and 3.0.0.

@AegisCrusader
Copy link
Author

One of them, I suppose, is support for Lua 5.4.3+ and more features all around. There isn't really a good changelog, though there seems to be some more flexibility with TCP options (which is what I'm mainly working with right now), especially when used with Linux.

@MikuAuahDark
Copy link
Contributor

Looks like one of the breaking change is reported lunarmodules/luasocket#371

@AegisCrusader
Copy link
Author

Interesting. Yea, they'll probably need to sort that stuff out first.

@slime73
Copy link
Member

slime73 commented Apr 3, 2022

love is actually using a more recent version of luasocket than the 3.0rc1 tag (although it's still pretty old now): lunarmodules/luasocket@316a945 - according to the comments of that breaking change issue, the commit which introduced the problem is older than what we use, so by updating to the tagged 3.0.0 release we won't be introducing that issue at least (since it's already there).

@slime73 slime73 added this to the 12.0 milestone Apr 3, 2022
@slime73 slime73 added the change Change to existing functionality label Apr 3, 2022
@MikuAuahDark
Copy link
Contributor

Another issue is reported: lunarmodules/luasocket#375

I probably have to hold the upgrade until the issues are resolved.

@MikuAuahDark MikuAuahDark added the library dependency Related to a library used by LÖVE label Apr 16, 2022
@MikuAuahDark
Copy link
Contributor

Looks like LuaSocket is "stable enough" and the other issue in question has not getting any reply since, thus it's probably an invalid issue.

@MikuAuahDark MikuAuahDark self-assigned this Oct 7, 2022
@MikuAuahDark MikuAuahDark linked a pull request Oct 8, 2022 that will close this issue
@slime73
Copy link
Member

slime73 commented Oct 8, 2022

Implemented via 7a85dc9

@slime73 slime73 closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Change to existing functionality library dependency Related to a library used by LÖVE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants