-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LuaSocket has released version 3.0.0 #1790
Comments
I'd like to know if there are any breaking changes between 3.0.0-rc1 and 3.0.0. |
One of them, I suppose, is support for Lua 5.4.3+ and more features all around. There isn't really a good changelog, though there seems to be some more flexibility with TCP options (which is what I'm mainly working with right now), especially when used with Linux. |
Looks like one of the breaking change is reported lunarmodules/luasocket#371 |
Interesting. Yea, they'll probably need to sort that stuff out first. |
love is actually using a more recent version of luasocket than the 3.0rc1 tag (although it's still pretty old now): lunarmodules/luasocket@316a945 - according to the comments of that breaking change issue, the commit which introduced the problem is older than what we use, so by updating to the tagged 3.0.0 release we won't be introducing that issue at least (since it's already there). |
Another issue is reported: lunarmodules/luasocket#375 I probably have to hold the upgrade until the issues are resolved. |
Looks like LuaSocket is "stable enough" and the other issue in question has not getting any reply since, thus it's probably an invalid issue. |
Implemented via 7a85dc9 |
https://github.com/lunarmodules/luasocket/releases/tag/v3.0.0
Do you think we should put it in Love 12.x?
The text was updated successfully, but these errors were encountered: