Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[groups] pausing groups does show children as paused without pausing them #4696

Open
1 task done
Tealk opened this issue Apr 20, 2024 · 8 comments · May be fixed by #5193
Open
1 task done

[groups] pausing groups does show children as paused without pausing them #4696

Tealk opened this issue Apr 20, 2024 · 8 comments · May be fixed by #5193
Labels
area:dashboard The main dashboard page where monitors' status are shown area:monitor Everything related to monitors bug Something isn't working help wanted May need your help to test or answer

Comments

@Tealk
Copy link

Tealk commented Apr 20, 2024 •
edited by CommanderStorm
Loading

📑 I have found these related issues/pull requests

🛡️ Security Policy

Description

If you pause the folder, the underlying elements are also displayed as paused, but notifications are still sent.

👟 Reproduction steps

Create a folder and a child element
Add a notification to the child element
Pause the folder
create an error

👀 Expected behavior

no notification is sent because all elements are paused
image

😓 Actual Behavior

notifications are sent
image

🐻 Uptime-Kuma Version

1.23.12

💻 Operating System and Arch

Debian 12 (bookworm)

🌐 Browser

Firefox 125.0.1 (64-bit)

🖥️ Deployment Environment

  • Runtime: docker
  • Database: sqlite
  • Filesystem used to store the database on: ZFS
  • number of monitors: 42

📝 Relevant log output

No response
@Tealk Tealk added the bug Something isn't working label Apr 20, 2024
@CommanderStorm

This comment was marked as outdated.

Sign in to view
@CommanderStorm CommanderStorm added question Further information is requested cannot-reproduce area:monitor Everything related to monitors labels Apr 20, 2024
@CommanderStorm CommanderStorm changed the title Notification of the child elements when the folder is paused [groups] Notification of the child elements when the folder is paused Apr 20, 2024
@Tealk

This comment was marked as outdated.

Sign in to view
@CommanderStorm

This comment was marked as outdated.

Sign in to view
@Tealk

This comment was marked as outdated.

Sign in to view
@CommanderStorm
Copy link
Collaborator

Okay, somehow my testing mechanism was a bit flawed.
I re-tried reproducing it on https://uptime.kuma.pet/ monitoring https://beeceptor.com/ was able to do so.

@CommanderStorm CommanderStorm added help wanted May need your help to test or answer and removed question Further information is requested cannot-reproduce labels Apr 21, 2024
@Tealk
Copy link
Author

Tealk commented Apr 21, 2024

if there is anything I can do, please let me know

@CommanderStorm
Copy link
Collaborator

I would love to have a contributor debug this.
I currently don't have the time to spend on that due to personal reasons (writing a bachelor thesis), but do have the time to review PRs.
Our contribution guide is found here: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

Debugging this would require stepping through the code with a debugger and see where/why

  • monitors are not getting paused or
  • are ignoring being paused

@CommanderStorm CommanderStorm changed the title [groups] Notification of the child elements when the folder is paused [groups] pausing groups does show children as paused without pausing them Apr 21, 2024
@CommanderStorm CommanderStorm mentioned this issue Apr 25, 2024
Closed
2 tasks
@CommanderStorm CommanderStorm added the area:dashboard The main dashboard page where monitors' status are shown label Apr 25, 2024
@FraatTailscale
Copy link

I have the same issue, have paused 82 devices but still get pushover notifications fom the paused devices.

@julian-piehl julian-piehl linked a pull request Oct 12, 2024 that will close this issue
Open
7 tasks
@CommanderStorm CommanderStorm mentioned this issue Oct 13, 2024
Merged
7 tasks
@CommanderStorm CommanderStorm mentioned this issue Oct 31, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:dashboard The main dashboard page where monitors' status are shown area:monitor Everything related to monitors bug Something isn't working help wanted May need your help to test or answer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pause child monitors if parent is paused julian-piehl/uptime-kuma
3 participants
@Tealk @CommanderStorm @FraatTailscale