-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No non-jQuery version #28
Comments
I've made a no-jQuery, pure-JS fork: https://github.com/MattX/highlight-within-textarea. Please let me know if you have any issues! |
Very cool MattX! I haven't had much time to maintain this project but I'll take a closer look this weekend. When I first started this project, jQuery was an obvious choice, but the web has moved on. I'm not thrilled about the jQuery dependency. |
Thanks! I made this fork assuming you weren't interested in merging it (if nothing else, because it changes the API), so I changed the package info / demo page to reduce confusion. Let me know if you want me to revert that and open a PR. |
@MattX your version seems to be missing |
@MattX you will publish your version to npm?! |
@rwwagner90—that's correct, I didn't port the destroy part because I didn't really need it... If you want to submit a PR to add that I'll be happy to merge it in. @brunoocasali—good idea, I'll publish it this week! |
@MattX I definitely think adding |
Should just be as easy as adding this to the highlight js. You just need to revert everything back to the original state that you had it and remove the events that were attached to your textarea. @MattX correct me if I'm wrong. |
For some sites, jQuery is too big a dependency.
The text was updated successfully, but these errors were encountered: