Skip to content

Commit 7b85f9d

Browse files
committed
fix(account): use regenerate route for generating new backup codes
The "Generate new backup codes" button was redirecting back immediately because BackupCodeBinding component checks for existing backup codes and redirects if isRegenerate is false. Added a separate regenerate route that passes isRegenerate prop to fix this issue.
1 parent 540eadd commit 7b85f9d

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

packages/account/src/App.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import {
2626
authenticatorAppRoute,
2727
authenticatorAppSuccessRoute,
2828
backupCodesGenerateRoute,
29+
backupCodesRegenerateRoute,
2930
backupCodesSuccessRoute,
3031
backupCodesManageRoute,
3132
passkeyAddRoute,
@@ -116,6 +117,7 @@ const Main = () => {
116117
<Route path={usernameRoute} element={<Username />} />
117118
<Route path={authenticatorAppRoute} element={<TotpBinding />} />
118119
<Route path={backupCodesGenerateRoute} element={<BackupCodeBinding />} />
120+
<Route path={backupCodesRegenerateRoute} element={<BackupCodeBinding isRegenerate />} />
119121
<Route path={backupCodesManageRoute} element={<BackupCodeView />} />
120122
<Route path={passkeyAddRoute} element={<PasskeyBinding />} />
121123
<Route path={passkeyManageRoute} element={<PasskeyView />} />

packages/account/src/constants/routes.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ export const passwordSuccessRoute = '/password/success';
99
export const authenticatorAppRoute = '/authenticator-app';
1010
export const authenticatorAppSuccessRoute = '/authenticator-app/success';
1111
export const backupCodesGenerateRoute = '/backup-codes/generate';
12+
export const backupCodesRegenerateRoute = '/backup-codes/regenerate';
1213
export const backupCodesManageRoute = '/backup-codes/manage';
1314
export const backupCodesSuccessRoute = '/backup-codes/success';
1415
export const passkeyAddRoute = '/passkey/add';

packages/account/src/pages/BackupCodeView/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import PageContext from '@ac/Providers/PageContextProvider/PageContext';
88
import { type BackupCodeItem, getBackupCodesList } from '@ac/apis/mfa';
99
import ErrorPage from '@ac/components/ErrorPage';
1010
import VerificationMethodList from '@ac/components/VerificationMethodList';
11-
import { backupCodesGenerateRoute } from '@ac/constants/routes';
11+
import { backupCodesRegenerateRoute } from '@ac/constants/routes';
1212
import useApi from '@ac/hooks/use-api';
1313
import SecondaryPageLayout from '@ac/layouts/SecondaryPageLayout';
1414

@@ -117,7 +117,7 @@ const BackupCodeView = () => {
117117
title="account_center.backup_code.generate_new"
118118
type="secondary"
119119
onClick={() => {
120-
void navigate(backupCodesGenerateRoute);
120+
void navigate(backupCodesRegenerateRoute);
121121
}}
122122
/>
123123
</div>

0 commit comments

Comments
 (0)