test

Author: Alexandru Ormenisan

python/hsml/model.py

@@ -302,11 +302,12 @@ def get_feature_view(self, init: bool = True, online: Optional[bool] = None):
         if init:
             td_prov = self.get_training_dataset_provenance()
             td = explicit_provenance.Links.get_one_accessible_parent(td_prov)
-            if online:
-                _logger.info("Initializing serving")
-                fv.init_serving(training_dataset_version=td.version)
-            elif os.environ["DEPLOYMENT_NAME"]:
-                _logger.info("Initializing serving - deployment detected")
+            is_deployment = "DEPLOYMENT_NAME" in os.environ
+            if online or is_deployment:
+                _logger.info(
+                    "Initializing serving"
+                    + (" - deployment detected" if is_deployment else "")
+                )
                 fv.init_serving(training_dataset_version=td.version)
             elif online is False:
                 _logger.info("Initializing batch")

python/hsml/model_serving.py

@@ -89,7 +89,7 @@ def get_deployment(self, name: str = None):
             `RestAPIError`: If unable to retrieve deployment from model serving.
         """
 
-        if name is None and os.environ["DEPLOYMENT_NAME"]:
+        if name is None and ("DEPLOYMENT_NAME" in os.environ):
             name = os.environ["DEPLOYMENT_NAME"]
         return self._serving_api.get(name)
 

python/tests/test_model.py

@@ -15,10 +15,12 @@
 #
 
 import copy
+import os
 
 import humps
 from hsml import model
 from hsml.constants import MODEL
+from hsml.core import explicit_provenance
 
 
 class TestModel:
@@ -398,3 +400,71 @@ def assert_model(self, mocker, m, m_json, model_framework):
         mock_read_file.assert_called_once_with(
             model_instance=m, resource=m_json["environment"]
         )
+
+    def test_get_feature_view(self, mocker):
+        mock_fv = mocker.Mock()
+        links = explicit_provenance.Links(accessible=[mock_fv])
+        mock_fv_provenance = mocker.patch(
+            "hsml.model.Model.get_feature_view_provenance", return_value=links
+        )
+        mock_td_provenance = mocker.patch(
+            "hsml.model.Model.get_training_dataset_provenance", return_value=links
+        )
+        mocker.patch("os.environ", return_value={})
+        m = model.Model(1, "test")
+        m.get_feature_view()
+        mock_fv_provenance.assert_called_once()
+        mock_td_provenance.assert_called_once()
+        assert not mock_fv.init_serving.called
+        assert not mock_fv.init_batch_scoring.called
+
+    def test_get_feature_view_online(self, mocker):
+        mock_fv = mocker.Mock()
+        links = explicit_provenance.Links(accessible=[mock_fv])
+        mock_fv_provenance = mocker.patch(
+            "hsml.model.Model.get_feature_view_provenance", return_value=links
+        )
+        mock_td_provenance = mocker.patch(
+            "hsml.model.Model.get_training_dataset_provenance", return_value=links
+        )
+        mocker.patch("os.environ", return_value={})
+        m = model.Model(1, "test")
+        m.get_feature_view(online=True)
+        mock_fv_provenance.assert_called_once()
+        mock_td_provenance.assert_called_once()
+        assert mock_fv.init_serving.called
+        assert not mock_fv.init_batch_scoring.called
+
+    def test_get_feature_view_batch(self, mocker):
+        mock_fv = mocker.Mock()
+        links = explicit_provenance.Links(accessible=[mock_fv])
+        mock_fv_provenance = mocker.patch(
+            "hsml.model.Model.get_feature_view_provenance", return_value=links
+        )
+        mock_td_provenance = mocker.patch(
+            "hsml.model.Model.get_training_dataset_provenance", return_value=links
+        )
+        mocker.patch("os.environ", return_value={})
+        m = model.Model(1, "test")
+        m.get_feature_view(online=False)
+        mock_fv_provenance.assert_called_once()
+        mock_td_provenance.assert_called_once()
+        assert not mock_fv.init_serving.called
+        assert mock_fv.init_batch_scoring.called
+
+    def test_get_feature_view_deployment(self, mocker):
+        mock_fv = mocker.Mock()
+        links = explicit_provenance.Links(accessible=[mock_fv])
+        mock_fv_provenance = mocker.patch(
+            "hsml.model.Model.get_feature_view_provenance", return_value=links
+        )
+        mock_td_provenance = mocker.patch(
+            "hsml.model.Model.get_training_dataset_provenance", return_value=links
+        )
+        mocker.patch.dict(os.environ, {"DEPLOYMENT_NAME": "test"})
+        m = model.Model(1, "test")
+        m.get_feature_view()
+        mock_fv_provenance.assert_called_once()
+        mock_td_provenance.assert_called_once()
+        assert mock_fv.init_serving.called
+        assert not mock_fv.init_batch_scoring.called