Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zod 3.24.x #4959

Closed
1 of 5 tasks
genu opened this issue Dec 11, 2024 · 5 comments
Closed
1 of 5 tasks

Support zod 3.24.x #4959

genu opened this issue Dec 11, 2024 · 5 comments
Labels
🤔 needs reproduction This issue requires a demo

Comments

@genu
Copy link
Contributor

genu commented Dec 11, 2024

What happened?

When using toTypedSchema for a zod schema a incompatible type error is thrown related to ZodIssue

Starting in zod 3.24, @standard-schema/spec is implemented which I believe is the reason

Reproduction steps

  1. Upgrade zod dependency to version 3.24.x
    ...

Version

Vue.js 3.x and vee-validate 4.x

What browsers are you seeing the problem on?

  • Firefox
  • Chrome
  • Safari
  • Microsoft Edge

Relevant log output

No response

Demo link

https://stackblitz.com/edit/github-kdegep-dfaa5wba?file=package.json

Code of Conduct

@logaretm
Copy link
Owner

logaretm commented Dec 11, 2024

Not getting this error myself, I can bump the dependencies but before i start requiring everyone to upgrade their zod version. can you add a repro?

@logaretm logaretm added the 🤔 needs reproduction This issue requires a demo label Dec 11, 2024
@genu
Copy link
Contributor Author

genu commented Dec 11, 2024

I'll try to get a repro together and attach

@genu
Copy link
Contributor Author

genu commented Dec 12, 2024

Here is a repro: https://stackblitz.com/edit/github-kdegep-dfaa5wba?file=package.json

now that I come to think of it, It might be a tooling issue related to typescript 5.7.2

Possibly related to vuejs/language-tools#5044
and to: vuejs/language-tools#5018

@genu
Copy link
Contributor Author

genu commented Dec 12, 2024

After digging further, There was some wonky dependency issues. I deleted my lock file, and problem went a way.

Closing for now.

@genu genu closed this as completed Dec 12, 2024
@logaretm
Copy link
Owner

Thanks for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤔 needs reproduction This issue requires a demo
Projects
None yet
Development

No branches or pull requests

2 participants