Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation issue #143

Open
satishdotpatel opened this issue Sep 1, 2021 · 5 comments
Open

Input validation issue #143

satishdotpatel opened this issue Sep 1, 2021 · 5 comments

Comments

@satishdotpatel
Copy link

satishdotpatel commented Sep 1, 2021

I am running stable pdns manager GUI and today noticed someone just hit "Add" button which added empty record in powerDNS caused outage and DNS failed to start.

Does input validation not working or something went wrong here?

@satishdotpatel
Copy link
Author

Any update or fix here?

@BotoX
Copy link

BotoX commented May 4, 2022

Check out my fork, made some improvements there: https://github.com/BotoX/pdnsmanager
Input filtering + validation is one of them.

@bertvandepoel
Copy link

This extra filtering and validation comes in really handy @BotoX! I wish there was a release though, or ideally that it could be integrated into the main release. That would make things a lot more convenient.

@bertvandepoel
Copy link

Hmmm, tried to build it and wasn't successful. I feel like that release is even more necessary now 😅

@BotoX
Copy link

BotoX commented Jun 2, 2023

Hmmm, tried to build it and wasn't successful. I feel like that release is even more necessary now sweat_smile

I've followed the travis.yml to install the right dependencies and build the project:
https://github.com/loewexy/pdnsmanager/blob/master/.travis.yml

Try that, else I could probably make a release.

Basically just "npm run build" in the frontend folder and "composer install" in the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants