OLC integration

[LauraErhard]

While writing the report we stumbled on the promised integration of OLCs.
According to #104 we have the Sowi-OLC implemented so that we could get metadata of journal articles from there, if we input the OLC_PPN. But we only have the possibility to choose DOI.
@abdelqader-mohammad is this only an issue of the frontend and you can just give us the possibility to choose OLC_PPN while ingesting data (for journal articles)?

[abdelqader-mohammad]

I added OLC_PPN beside DOI to the Journal article resource type.
@LauraErhard can you test the dev?

[LauraErhard]

Sadly it didn't work:
Object { headers: {…}, status: 400, statusText: "Bad Request", url: "https://locdb.bib.uni-mannheim.de/locdb-dev/saveResource", ok: false, name: "HttpErrorResponse", message: "Http failure response for https://locdb.bib.uni-mannheim.de/locdb-dev/saveResource: 400 Bad Request", error: {…} }

[abdelqader-mohammad]

It seems this error looks like the K10plus identifier error #445
I found that the function saveResource in the corresponding controller does not have any implementation for OLC identifiers.

case enums.identifier.olcPpn:
       // go to olc and create article
       return response.status(400).json({"message": "Identifier type not implemented."});

@lgalke what do you think?

[lgalke]

I suspected that also. The identifier restrictions are based on what is implemented in the back-end.

[LauraErhard]

Thank you both for looking into this.
I found out, that our k10plus API seems to include the OLC databases, would it be a huge inconvenience for you to add the ID_k10plus to the journal article ingestion to test if it is implemented in the backend?

[abdelqader-mohammad]

From the frontend side, it is easy to add it.
But the problem is that the current implemetion of the scan controller is accepting only OLC or DOI as below:

case enums.resourceType.journalArticle:
                if (identifier.scheme !== enums.identifier.olcPpn && identifier.scheme !== enums.identifier.doi) {
                    return response.status(400).json({"message": "Not the appropriate input data for creating a journal article."})
                } else {
......

The backend needs to add the implementation for the required identifiers. Currently, it only saves the journals with DOI identifiers.

[LauraErhard]

Oh okay, thanks for explaining.