Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse functionality #411

Open
LauraErhard opened this issue Oct 26, 2018 · 7 comments
Open

Browse functionality #411

LauraErhard opened this issue Oct 26, 2018 · 7 comments
Labels
back-end This issue needs to be addressed by the back-end. question There is an open question, to which an answer is required to resolve the issue. testing

Comments

@LauraErhard
Copy link

I noticed that if I browse I only see 10 results at a time (even though I said filter for 40 results) and there is no possibility to show all. Is there a bug preventing more results to show?

On top of that it would be really nice if we had the same filters as for the suggestion search (Source, Type, Contained, Year)
@lgalke
Copy link
Member

lgalke commented Oct 28, 2018

Filtering is added. The browse component has no display limit, and therefore no 'Show more' button. We display everything that is supplied by the back-end.

@lgalke
Copy link
Member

lgalke commented Oct 28, 2018

Please test again, if there are really too few resources returned. Please also consider the number of results limit, which is per default at 20.

@LauraErhard
Copy link
Author

The filters are working fine, thanks for that.

Are you sure about the 20 search results. I just tried different searches and I can't believe that even for a search with just and I get back exactly 10 results. It seems to me, that the default is somehow at 10 and even changing the number doesn't change anything.

I noticed something curious too. Normally the internal suggestions don't have a source in yellow at the end. But now I see them sometimes (in dev):
browse
Is this just an anomaly from the dev version and shouldn't happen in the prod? Or is there a bug somewhere?

@lgalke
Copy link
Member

lgalke commented Oct 29, 2018

It comes from migrated suggestions. The source property is taken as is and saved. Would you prefer to have it removed instead?

About the spurious 10 limit @anlausch, do you have an idea? I'm calling the internalSuggestions API with the user-defined number as threshold.

@lgalke lgalke added question There is an open question, to which an answer is required to resolve the issue. back-end This issue needs to be addressed by the back-end. labels Oct 30, 2018
@kleinann
Copy link

I noticed something similar today: The resource "Democracy in America" is found when I search with the exact title, but it's not in the list when I just search for "america". It actually was before I changed its resource type from "Monograph" to "Book set" - but that can probably not be the reason for disappearing.

@kleinann
Copy link

Not necessarily for the workshop, but in general: Could we make identifiers searchable?

@lgalke
Copy link
Member

lgalke commented Nov 2, 2018

The resource "Democracy in America" is found when I search with the exact title, but it's not in the list when I just search for "america".

I'm just guessing: maybe the comparison is case-sensitive.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
back-end This issue needs to be addressed by the back-end. question There is an open question, to which an answer is required to resolve the issue. testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lgalke @LauraErhard @kleinann