Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to include tagged commits on either beginning or end of range #60

Open
colecarroll opened this issue May 14, 2020 · 1 comment
Open

Comments

@colecarroll
Copy link

I'm importing this package into my code and trying to generate a changelog with tags. It always excludes the tagged commits and includes everything between the beginning and end.

It would be nice if you could provide an option or flag to include the tagged commits into the changelog.

E.g.,

Currently
Commit1
Commit2
Commit3
Commit4
Commit5

Commit1 and Commit 5 are excluded from the changelog.

It would be nice if you could provide an option to include them.

Can I put out a PR for that change?

@ScottBrenner
Copy link
Contributor

If I'm not mistaken, this is supposed to be run before the tag is created.

This is meant to be used so that for every patch, minor, or major version, you update the changelog prior to running npm version so that the git tag contains the commit that updated both the changelog and version.

from https://github.com/lob/generate-changelog#generate-changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants