File tree Expand file tree Collapse file tree 8 files changed +14
-9
lines changed
codeEditor/browser/quickaccess
services/timer/electron-sandbox Expand file tree Collapse file tree 8 files changed +14
-9
lines changed Original file line number Diff line number Diff line change @@ -233,7 +233,7 @@ export class CodeWindow extends Disposable implements ICodeWindow {
233233 this . _win . setSheetOffset ( 22 ) ; // offset dialogs by the height of the custom title bar if we have any
234234 }
235235
236- // TODO@Ben (Electron 4 regression): when running on multiple displays where the target display
236+ // TODO@bpasero (Electron 4 regression): when running on multiple displays where the target display
237237 // to open the window has a larger resolution than the primary display, the window will not size
238238 // correctly unless we set the bounds again (https://github.com/microsoft/vscode/issues/74872)
239239 //
@@ -568,7 +568,7 @@ export class CodeWindow extends Disposable implements ICodeWindow {
568568 // Unresponsive
569569 if ( error === WindowError . UNRESPONSIVE ) {
570570 if ( this . isExtensionDevelopmentHost || this . isExtensionTestHost || ( this . _win && this . _win . webContents && this . _win . webContents . isDevToolsOpened ( ) ) ) {
571- // TODO@Ben Workaround for https://github.com/microsoft/vscode/issues/56994
571+ // TODO@bpasero Workaround for https://github.com/microsoft/vscode/issues/56994
572572 // In certain cases the window can report unresponsiveness because a breakpoint was hit
573573 // and the process is stopped executing. The most typical cases are:
574574 // - devtools are opened and debugging happens
Original file line number Diff line number Diff line change @@ -278,7 +278,7 @@ export interface IFileSystemProvider {
278278 readonly capabilities : FileSystemProviderCapabilities ;
279279 readonly onDidChangeCapabilities : Event < void > ;
280280
281- readonly onDidErrorOccur ?: Event < string > ; // TODO@ben remove once file watchers are solid
281+ readonly onDidErrorOccur ?: Event < string > ; // TODO@bpasero remove once file watchers are solid
282282
283283 readonly onDidChangeFile : Event < readonly IFileChange [ ] > ;
284284 watch ( resource : URI , opts : IWatchOptions ) : IDisposable ;
Original file line number Diff line number Diff line change @@ -522,7 +522,7 @@ export class DiskFileSystemProvider extends Disposable implements
522522 return this . watchRecursive ( resource , opts . excludes ) ;
523523 }
524524
525- return this . watchNonRecursive ( resource ) ; // TODO@ben ideally the same watcher can be used in both cases
525+ return this . watchNonRecursive ( resource ) ; // TODO@bpasero ideally the same watcher can be used in both cases
526526 }
527527
528528 private watchRecursive ( resource : URI , excludes : string [ ] ) : IDisposable {
Original file line number Diff line number Diff line change @@ -55,10 +55,15 @@ export class GotoSymbolQuickAccessProvider extends AbstractGotoSymbolQuickAccess
5555 }
5656
5757 protected get activeTextEditorControl ( ) {
58+ // TODO@bpasero this distinction should go away by adopting `IOutlineService`
59+ // for all editors (either text based ones or not). Currently text based
60+ // editors are not yet using the new outline service infrastructure but the
61+ // "classical" document symbols approach.
62+
5863 if ( isCompositeEditor ( this . editorService . activeEditorPane ?. getControl ( ) ) ) {
59- // TODO@bpasero adopt IOutlineService for "normal" document symbols.
6064 return undefined ;
6165 }
66+
6267 return this . editorService . activeTextEditorControl ;
6368 }
6469
Original file line number Diff line number Diff line change @@ -128,7 +128,7 @@ export abstract class AbstractFileOutputChannelModel extends Disposable implemen
128128 }
129129}
130130
131- // TODO@ben see if new watchers can cope with spdlog and avoid polling then
131+ // TODO@bpasero see if new watchers can cope with spdlog and avoid polling then
132132class OutputFileListener extends Disposable {
133133
134134 private readonly _onDidContentChange = new Emitter < number | undefined > ( ) ;
Original file line number Diff line number Diff line change @@ -148,7 +148,7 @@ class DesktopMain extends Disposable {
148148 private onWindowResize ( e : Event , retry : boolean , workbench : Workbench ) : void {
149149 if ( e . target === window ) {
150150 if ( window . document && window . document . body && window . document . body . clientWidth === 0 ) {
151- // TODO@Ben this is an electron issue on macOS when simple fullscreen is enabled
151+ // TODO@bpasero this is an electron issue on macOS when simple fullscreen is enabled
152152 // where for some reason the window clientWidth is reported as 0 when switching
153153 // between simple fullscreen and normal screen. In that case we schedule the layout
154154 // call at the next animation frame once, in the hope that the dimensions are
Original file line number Diff line number Diff line change @@ -120,7 +120,7 @@ class DesktopMain extends Disposable {
120120 private onWindowResize ( e : Event , retry : boolean , workbench : Workbench ) : void {
121121 if ( e . target === window ) {
122122 if ( window . document && window . document . body && window . document . body . clientWidth === 0 ) {
123- // TODO@Ben this is an electron issue on macOS when simple fullscreen is enabled
123+ // TODO@bpasero this is an electron issue on macOS when simple fullscreen is enabled
124124 // where for some reason the window clientWidth is reported as 0 when switching
125125 // between simple fullscreen and normal screen. In that case we schedule the layout
126126 // call at the next animation frame once, in the hope that the dimensions are
Original file line number Diff line number Diff line change @@ -83,7 +83,7 @@ export class TimerService extends AbstractTimerService {
8383//#region cached data logic
8484
8585export function didUseCachedData ( ) : boolean {
86- // TODO@Ben TODO@Jo need a different way to figure out if cached data was used
86+ // TODO@bpasero TODO@jrieken need a different way to figure out if cached data was used
8787 if ( context . sandbox ) {
8888 return true ;
8989 }
You can’t perform that action at this time.
0 commit comments