You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Structures in HLSL's StructuredBuffer need to be treated as packed, or otherwise made to skip adding any padding for compatibility with DXC.
Note: dxc does this by hacking padding off of all structures in CGRecordLowering::lower, like so:
#if0 // HLSL Change - No padding for structure. Array offset will be handled when load/store is called
Members.push_back(StorageInfo(Size, getIntNType(8)));
clipTailPadding();
determinePacked(NVBaseType);
insertPadding();
Members.pop_back();
calculateZeroInit();
#endif// HLSL Change End
This is obviously not how we should handle this in upstream.
The text was updated successfully, but these errors were encountered:
This moves the current structured buffer test to a new file and
introduces a simpler one that doesn't need llvm/llvm-project#104503 and
llvm/llvm-project#121010 to be in place in order to pass.
Note: this would be better if it exercised both SRVs and UAVs, but SRV
support isn't implemented in the test framework yet.
Structures in HLSL's StructuredBuffer need to be treated as packed, or otherwise made to skip adding any padding for compatibility with DXC.
Note:
dxc
does this by hacking padding off of all structures in CGRecordLowering::lower, like so:This is obviously not how we should handle this in upstream.
The text was updated successfully, but these errors were encountered: