Fix last set of compiler warnings after messing up on not being up to date with the remote branch...

Author: rcarson3

src/options/option_post_processing.cpp

@@ -90,7 +90,7 @@ LightUpOptions parse_legacy_light_up(const toml::value& toml_input) {
 
     // Parse sample direction (light_s_dir -> sample_direction)
     if (viz_table.contains("light_s_dir")) {
-        const auto& dir = toml::find(toml_input, "light_s_dir");
+        const auto dir = toml::find(toml_input, "light_s_dir");
         if (dir.at(0).is(toml::value_t::integer)) {
             auto dir_vec = toml::get<std::vector<int>>(dir);
             if (dir_vec.size() >= 3) {
@@ -181,7 +181,7 @@ LightUpOptions LightUpOptions::from_toml(const toml::value& toml_input) {
     }
 
     if (toml_input.contains("light_s_dir")) {
-        const auto& dir = toml::find(toml_input, "light_s_dir");
+        const auto dir = toml::find(toml_input, "light_s_dir");
         if (dir.at(0).is(toml::value_t::integer)) {
             auto dir_vec = toml::get<std::vector<int>>(dir);
             if (dir_vec.size() >= 3) {
@@ -194,7 +194,7 @@ LightUpOptions LightUpOptions::from_toml(const toml::value& toml_input) {
             } 
         }
     } else if (toml_input.contains("sample_direction")) {
-        const auto& dir = toml::find(toml_input, "sample_direction");
+        const auto dir = toml::find(toml_input, "sample_direction");
         if (dir.at(0).is(toml::value_t::integer)) {
             auto dir_vec = toml::get<std::vector<int>>(dir);
             if (dir_vec.size() >= 3) {

src/postprocessing/postprocessing_file_manager.hpp

@@ -509,9 +509,9 @@ inline bool PostProcessingFileManager::EnsureDirectoryExists(fs::path& output_di
 
     // Broadcast the potentially updated output_dir to all ranks
     std::string path_str = output_dir.string();
-    int dir_length = path_str.length();
+    int dir_length = static_cast<int>(path_str.length());
     MPI_Bcast(&dir_length, 1, MPI_INT, 0, comm);
-    path_str.resize(dir_length);
+    path_str.resize(static_cast<size_t>(dir_length));
     MPI_Bcast(&path_str[0], dir_length, MPI_CHAR, 0, comm);
     output_dir = path_str;
 

src/system_driver.cpp

@@ -88,7 +88,7 @@ namespace {
       max_origin.HostReadWrite();
       // We need to calculate the minimum point in the mesh to get the correct velocity gradient across
       // the part.
-      RAJA::RangeSegment default_range(0, nnodes);
+      RAJA::RangeSegment default_range(0, static_cast<long>(nnodes));
       if (class_device == RTModel::CPU) {
          for (int j = 0; j < space_dim; j++) {
             RAJA::ReduceMin<RAJA::seq_reduce, double> seq_min(std::numeric_limits<double>::max());