Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve livepeer_value_redeemed metric implementation #2917

Closed
rickstaa opened this issue Dec 8, 2023 · 3 comments
Closed

Improve livepeer_value_redeemed metric implementation #2917

rickstaa opened this issue Dec 8, 2023 · 3 comments
Labels
status: triage this issue has not been evaluated yet

Comments

@rickstaa
Copy link
Member

rickstaa commented Dec 8, 2023

Improved Bug Report

Describe the Bug

The current implementation of the ValueRedeemed metric in the go-livepeer codebase exhibits behaviour where the metric is exposed only upon invoking the redeem winning ticket method (see these lines of code). The issue arises from the fact that the metric counter is not published when the go-livepeer client is restarted, as observed in the redeemed value panel of my orchestrator dashboard.

To Reproduce

  1. Start the go-livepeer binary with the -monitor flag.
  2. Visit http://localhost:7936/metrics and note the absence of the livepeer_value_redeemed metric.
  3. Check the redeemed value panel in my orchestrator dashboard, confirming the metric is published only when a ticket is redeemed.

Expected Behavior

The livepeer_value_redeemed metric should function as a counter, initiating at 0. This adjustment ensures compatibility with Prometheus's increase method, enabling the metric to persist through binary restarts.

Screenshots

image

Desktop (Additional Information):

  • OS: Ubuntu 22.04
  • Version: a9a4b00
@github-actions github-actions bot added the status: triage this issue has not been evaluated yet label Dec 8, 2023
@leszko
Copy link
Contributor

leszko commented Dec 12, 2023

@rickstaa Thanks for raising the GH Issue!

I think it makes sense. Would you like to send a PR with the update?

@rickstaa
Copy link
Member Author

rickstaa commented Dec 12, 2023

@leszko This issue was fixed by @stronk-dev in #2916. As a result, it should not be present anymore on the main branch. I will test it out and close this issue 👍🏻.

@rickstaa
Copy link
Member Author

I am closing this since the issue has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: triage this issue has not been evaluated yet
Projects
None yet
Development

No branches or pull requests

2 participants