Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: PR Build Previews #15

Open
JacobCoffee opened this issue Jul 22, 2023 · 2 comments
Open

Enhancement: PR Build Previews #15

JacobCoffee opened this issue Jul 22, 2023 · 2 comments
Assignees
@provinzkraut
Labels
enhancement New feature or request

Comments

@JacobCoffee
Copy link
Member

Summary

Similar to https://github.com/litestar-org/litestar PRs, add site build previews so that other reviewers can see the change you are presenting without having to clone and build it themselves.

This is done with https://github.com/litestar-org/litestar/blob/main/.github/workflows/docs-preview.yaml in conjunction with https://github.com/litestar-org/litestar-docs-preview

Basic Example

No response

Drawbacks and Impact

No response

Unresolved questions

No response
@JacobCoffee JacobCoffee added the enhancement New feature or request label Jul 22, 2023
@JacobCoffee
Copy link
Member Author

@provinzkraut can you teach me how you did this

@provinzkraut
Copy link
Member

provinzkraut commented Jul 22, 2023 •
edited
Loading

Sure. Remind me of this some time and we can take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@provinzkraut provinzkraut

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@provinzkraut @JacobCoffee