-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improve windows CI build, CI for windows shared #353
Open
TYoungSL
wants to merge
31
commits into
litespeedtech:master
Choose a base branch
from
StirlingLabs:feature/appveyor-perf-run-vcpkg-fixes-windows-shared-pcre2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Improve windows CI build, CI for windows shared #353
TYoungSL
wants to merge
31
commits into
litespeedtech:master
from
StirlingLabs:feature/appveyor-perf-run-vcpkg-fixes-windows-shared-pcre2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add perf test after test run in appveyor-linux.yml make boringssl cache dependent on boringssl-target.txt cache apt's fetched libevent debs
add perf test for windows add .gitignore for generated files reduce build scope for windows builds through appveyor since appveyor sometimes times out connecting to github, add 10 attempt retry to submodule update
use pcre2 over pcre on windows (avoids weird import linkage issue under shared build) try installing debs directly from cache instead of apt updating copy depended dlls as needed for tests, bins fix regex lookup xplat
…especially) if they fail
make wevtutil louder
…f test remove diag code from linux and mac appveyor configs add 5 minute timeout for tests
increase verbosity from quiet to minimal fix dir removal failures on windows-shared comment ldd usage fix text errorlevel result being lost
…veyor-perf-run-vcpkg-fixes-windows-shared-pcre2 # Conflicts: # appveyor-linux.yml # appveyor-windows.cmd
@gwanglst do you have any idea about these tests failing? |
TYoungSL
force-pushed
the
feature/appveyor-perf-run-vcpkg-fixes-windows-shared-pcre2
branch
from
January 12, 2022 17:17
3e5a104
to
9069f16
Compare
I don't know why the shared tests are failing, but the PR is otherwise good to go for the existing 3 (non-shared) build paths. Since you have to set up appveyor manually to use the appveyor-windows-shared.yml config, it'll just be inactive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vcpkg fixes and updates.
Windows build uses PCRE2 (fixes shared linkage issues) with fallback to PCRE.
Changed to VS 2022 AppVeyor CI images to use newer vcpkg.
Fixes shared linkage issues when building bin targets and tests.
Adds a 10 minute test kill on windows appveyor test runs since CMake's test timeouts don't work on Windows.
Adds build-tests target to build tests without running them.
CI now runs perf_server / perf_client for a quick 100MB shot across localhost. (1.5s on linux, 3-5s on mac, longer on windows) using simple generated self-signed certs.
BoringSSL caching is partially restored on AppVeyor, but still must be rebuilt.
[WIP] Windows shared build currently fails some tests with SEGFAULT.
[WIP] Windows shared build currently fails some tests as the total test duration exceeds 10 minutes and they are killed.
Don't recommend merging this one yet. Need help diagnosing the segfaults and stream test overlong duration.