Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suspected Bug] Corner case in split_buffered_packet #505

Open
lxqwh opened this issue Jun 14, 2024 · 2 comments
Open

[Suspected Bug] Corner case in split_buffered_packet #505

lxqwh opened this issue Jun 14, 2024 · 2 comments

Comments

@lxqwh
Copy link

lxqwh commented Jun 14, 2024

image
I think that in the code above, the condition count > 1 should be changed to count >= 1. If the capacity of the new packet is 1 greater than that of the old packet (which is possible), then there's no need to split the old packet into two.
I encountered the above case in the test, which caused a disconnection.
Please check it !!!

@litespeedtech
Copy link
Owner

Can it be easily reproduced? I wonder why it happens. What frames are in the packet to be split? Maybe the split_lost_packet() should be avoided if it does not ending up splitting a packet.

@lxqwh
Copy link
Author

lxqwh commented Jun 14, 2024

image
It returned here in lsquic_packet_resize_next when second lsquic_packet_resize_next loop.
Not easily reproducible, no split error occurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants