Skip to content
This repository has been archived by the owner on Jul 15, 2018. It is now read-only.

Like sometimes not registering? #38

Open
hmpws opened this issue Jul 23, 2017 · 2 comments
Open

Like sometimes not registering? #38

hmpws opened this issue Jul 23, 2017 · 2 comments

Comments

@hmpws
Copy link

hmpws commented Jul 23, 2017

I have had some issues where I liked a person and the exact same person shows up again later. I haven't done enough testing to see whether this occurs only to people at the top of the list after scrolling down (i.e. new recommendations may have been pulled).

Does the user id and hash data get updated in the recommendation list if the same person is returned by Tinder? I understand that there is a specific user id and content id associated with each recommendation from Tinder, whether the content id actually affects the like command is conjecture though. (I was playing with a Python based Tinder script before and that inserts the hash data after the like command.)

@eddiewang
Copy link
Collaborator

It's not the cleanest code. We created the project to learn React and JavaScript, and there are definitely bugs and optimizations we could add, but don't have time for at this stage in time. You caught one of the common bugs, it has to do with how we filter the recommendations (spoiler: it's pretty badly done).

@hmpws
Copy link
Author

hmpws commented Jul 24, 2017

Yes, fair enough! I don't know enough about React nor JS unfortunately but tinkering is fun. I am guessing it is in this line from getRecommendations?

resolve(data.results.filter((each) => !each.is_brand));

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants