Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-BOLD-014 Informational 7.2: Bypassing Collateral Adjustment Check #478

Open
bingen opened this issue Oct 8, 2024 · 1 comment
Open
Assignees
Labels
ChainSecurity wontfix This will not be worked on

Comments

@bingen
Copy link
Collaborator

bingen commented Oct 8, 2024

The check BorrowerOperations._requireValidAdjustmentInCurrentMode prevents reducing collateral in undercollateralized troves (ICR < MCR).

It can be bypassed through self-redemptions, by first adjusting the interest rate of the trove to be the lowest in the branch, then redeeming from it.

@bingen bingen self-assigned this Oct 21, 2024
@bingen bingen added the wontfix This will not be worked on label Oct 21, 2024
@bingen
Copy link
Collaborator Author

bingen commented Oct 21, 2024

That workaround would:

  • Reduce the size of an undercollateralized trove
  • Improve the ICR of an undercollateralized trove
    So it’s not bad for the system.

That condition prevents the final state to be undercollateralized. So the only way to use that workaround and still end up with ICR < MCR is the trove was already undercollateralized. It doesn’t allow to convert a healthy trove into an undercollateralized one.

Therefore, we accept it for simplicity of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChainSecurity wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant