Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-BOLD-013 Informational 7.1: Backed Tokens Can Be Redeemed Unproportionally #477

Closed
bingen opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
ChainSecurity wontfix This will not be worked on

Comments

@bingen
Copy link
Collaborator

bingen commented Oct 8, 2024

In CollateralRegistry, the redeemCollateral function has a special case for when all active branches are fully "backed". In this case the function will redeem from all active branches proportionally to the branch debt.

However, an edge case that is not explicitly handled is when there is a branch with more than zero unbacked debt, but less than the requested _boldAmount (and the other branches are fully backed). In this case, the function will redeem only from this branch, even though the branch will also become fully backed during the redemption process. This means that "fully backed" branches can be redeemed unproportionally.

It is not clearly specified if this is expected behavior or not.

@bingen
Copy link
Collaborator Author

bingen commented Oct 22, 2024

there is a branch with more than zero unbacked debt, but less than the requested _boldAmount (and the other branches are fully backed)

If all the branches are fully backed except one, then the max amount that can be redeemed is the unbacked portion of that one branch, otherwise the sum of all SPs would exceed the total supply. So it seems to me that this scenario is impossible.

@bingen bingen self-assigned this Oct 22, 2024
@bingen bingen added the wontfix This will not be worked on label Oct 22, 2024
@bingen bingen closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChainSecurity wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant